fix: Connector image mismatch

[tomiir]

Description

• Fixes issue where selecting a wallet to connect to through the relay and connecting with a different one resulted in the wrong image being shown.
• Makes use of session.peer.metadata to use the proper image
• Removes usage of localstorage to handle the image
• Fixes issue with coinbase image being undefined.

Type of change

• Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-841

Checklist

• Code in this PR is covered by automated tests (Unit tests, E2E tests) => Not possible to test without having wallets to connect to via QR
• My changes generate no new warnings
• I have reviewed my own code
• I have filled out all required sections

[linear]

APKT-841 [bug] Incorrect wallet image shown if connecting to a different wallet than selected in Appkit

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	Aug 28, 2024 7:46pm
web3modal-laboratory	✅ Ready (Inspect)	Visit Preview	Aug 28, 2024 7:46pm

[github-actions]

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	72.16000000000001%	2392 / 8015
🔵	Statements	72.16000000000001%	2392 / 8015
🔵	Functions	108.56%	181 / 619
🔵	Branches	140.13%	300 / 675

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
packages/core/src/controllers/ConnectionController.ts	56.77%	90.9%	27.27%	56.77%	71-75, 82-83, 100-102, 105-118, 121-122, 125-126, 129-130, 133-134, 137-138, 141-142, 145-146, 149-150, 166-167, 170-172, 175-176, 179-180, 189-190
packages/core/src/utils/StorageUtil.ts	46.8%	66.66%	40%	46.8%	14-19, 22-29, 31-32, 43-56, 89-94, 97-101, 103-104, 107-111, 113-114

Generated in workflow #5850

[github-actions]

♻️ Vite-Size ♻️

Size Difference

	Size (kb)	Gzip (kb)
Total Diff.	0	0

Current Size

Name	Size (kb)	Gzip (kb)
assets/index-u0z_tHyt.js	1475.108	417.506
assets/noble-curves.js	31.941	12.779
assets/2.19.6_bufferutil.js	2.789	1.325
assets/index.js	161.83	59.282
assets/index2.js	102.249	29.113
assets/index3.js	304.389	87.28
assets/walletconnect-ethereum-provider.js	278.197	80.093
assets/index4.js	11.601	3.212
assets/w3m-modal.js	6.992	2.508
assets/index5.js	12.674	4.695
assets/hooks.module.js	74.776	25.682
assets/walletconnect-modal-ui.js	112.43	34.327
index.html	0.329	0.235
Total Size	2575.305	758.037

Base Size

Name	Size (kb)	Gzip (kb)
assets/index-u0z_tHyt.js	1475.108	417.506
assets/noble-curves.js	31.941	12.779
assets/2.19.6_bufferutil.js	2.789	1.325
assets/index.js	161.83	59.282
assets/index2.js	102.249	29.113
assets/index3.js	304.389	87.28
assets/walletconnect-ethereum-provider.js	278.197	80.093
assets/index4.js	11.601	3.212
assets/w3m-modal.js	6.992	2.508
assets/index5.js	12.674	4.695
assets/hooks.module.js	74.776	25.682
assets/walletconnect-modal-ui.js	112.43	34.327
index.html	0.329	0.235
Total Size	2575.305	758.037

[zoruka]

does Solana not have this same issue? Seems like it never calls this.appkit.setConnectedWalletInfo there 🤔.

[github-actions]

	Warnings
⚠️	Testing spec changed

Generated by 🚫 dangerJS against f191beb