Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make all socials enabled by default #2747

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Aug 27, 2024

Description

  • Makes all socials enabled by default

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-922

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

linear bot commented Aug 27, 2024

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Aug 28, 2024 2:49pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Aug 28, 2024 2:49pm

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery 🔄 Building (Inspect) Visit Preview Aug 27, 2024 7:30am
web3modal-laboratory 🔄 Building (Inspect) Visit Preview Aug 27, 2024 7:30am

Copy link
Contributor

github-actions bot commented Aug 27, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 72.08% 2403 / 8039
🔵 Statements 72.08% 2403 / 8039
🔵 Functions 108.42% 182 / 622
🔵 Branches 140.20000000000002% 301 / 676
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/ui/src/composites/wui-ens-input/index.ts 0% 0% 0% 0%
Generated in workflow #5835

Copy link
Contributor

github-actions bot commented Aug 27, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 🔺+0.299 🔺+0.067

Current Size

Name Size (kb) Gzip (kb)
assets/index-BRHRGaze.js 1475.765 417.627
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.325
assets/index.js 161.807 59.272
assets/index2.js 102.249 29.112
assets/index3.js 304.389 87.279
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.51
assets/index5.js 12.674 4.695
assets/hooks.module.js 74.776 25.683
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.235
Total Size 2575.939 758.153

Base Size

Name Size (kb) Gzip (kb)
assets/index-BRHRGaze.js 1475.765 417.627
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.325
assets/index.js 161.807 59.272
assets/index2.js 102.249 29.112
assets/index3.js 304.09 87.212
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.51
assets/index5.js 12.674 4.695
assets/hooks.module.js 74.776 25.683
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.235
Total Size 2575.64 758.086

Comment on lines 18 to 20
if (library === 'solana') {
return
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not solana?

@tomiir tomiir deleted the chore/social-enabled-by-defualt branch August 28, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants