Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solana sign all transactions #2772

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Aug 30, 2024

Description

Adds Solana signAllTransactions method for Solana Provider interface and implement it in all available Providers.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-978

Showcase (Optional)

Screen.Recording.2024-08-30.at.12.15.44.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

linear bot commented Aug 30, 2024

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Aug 30, 2024 8:09pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Aug 30, 2024 8:09pm

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 87.48% 3185 / 13190
🔵 Statements 87.48% 3185 / 13190
🔵 Functions 161.44% 236 / 723
🔵 Branches 214.74999999999997% 427 / 845
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/base/adapters/solana/web3js/providers/AuthProvider.ts 78.2% 88.23% 40.74% 78.2% 49-51, 53-54, 57, 59-62, 124-129, 131-132, 146-147, 164, 166, 169, 188-190, 192-193, 204, 208, 212, 216-217, 221
packages/base/adapters/solana/web3js/providers/WalletConnectProvider.ts 87.96% 82.5% 87.5% 87.96% 68, 70-72, 74-75, 85, 170-175, 177-178, 208, 240-242, 244, 247, 251-253, 255, 258
packages/base/adapters/solana/web3js/providers/WalletStandardProvider.ts 74.11% 82.35% 66.66% 74.11% 68-69, 72, 74-76, 78-79, 82, 84-86, 88-89, 92-93, 96-97, 122-123, 141-142, 169-170, 176-181, 183-184, 204-205, 225-226, 247-248, 257-258, 260-263
packages/base/adapters/solana/web3js/tests/mocks/W3mFrameProvider.ts 97.72% 84.61% 100% 97.72% 37
packages/base/adapters/solana/web3js/tests/mocks/WalletStandard.ts 100% 100% 100% 100%
Generated in workflow #5884

Copy link
Contributor

github-actions bot commented Aug 30, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-D08NYFqh.js 1475.276 417.542
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.326
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.281
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.51
assets/index5.js 12.674 4.697
assets/hooks.module.js 74.776 25.683
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.237
Total Size 2575.473 758.087

Base Size

Name Size (kb) Gzip (kb)
assets/index-D08NYFqh.js 1475.276 417.542
assets/noble-curves.js 31.941 12.78
assets/2.19.6_bufferutil.js 2.789 1.326
assets/index.js 161.83 59.283
assets/index2.js 102.249 29.113
assets/index3.js 304.389 87.281
assets/walletconnect-ethereum-provider.js 278.197 80.094
assets/index4.js 11.601 3.213
assets/w3m-modal.js 6.992 2.51
assets/index5.js 12.674 4.697
assets/hooks.module.js 74.776 25.683
assets/walletconnect-modal-ui.js 112.43 34.328
index.html 0.329 0.237
Total Size 2575.473 758.087

@Chator1
Copy link

Chator1 commented Sep 3, 2024

0xFD689e5f2d8d9Aec0aD328225Ae62FdBDdb30328
#2772 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants