fix: RPC requests causing modal to close #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…c-response-handling-close-modal
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
magiziz
approved these changes
Sep 4, 2024
…c-response-handling-close-modal
zoruka
approved these changes
Sep 5, 2024
Comment on lines
+39
to
+40
| const networkToSwitchButton = this.page.getByTestId(`w3m-network-switch-${network}`) | ||
| await networkToSwitchButton.click() |
There was a problem hiding this comment.
maybe not, it's a leftover from a debug session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
requestparameter to RPC resolver methods, to allow clients to check if the request that initiated them opened the modal before trying to close itType of change
Associated Issues
For Linear issues: Closes APKT-1002
Checklist