Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't capitalize first character of email field on mobile #2815

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Sep 6, 2024

Description

Currently on mobile when typing my email it auto-capitalizes the first character which, while is valid, is generally weird.

Current behavior:

screen-20240906-064619.mp4

New behavior:

screen-20240906-064955.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@chris13524 chris13524 self-assigned this Sep 6, 2024
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 10, 2024 0:19am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 10, 2024 0:19am

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 86.67% 3182 / 13432
🔵 Statements 86.67% 3182 / 13432
🔵 Functions 161.44% 236 / 723
🔵 Branches 215.42999999999998% 432 / 849
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/ui/src/composites/wui-email-input/index.ts 0% 0% 0% 0%
Generated in workflow #6042

@chris13524 chris13524 changed the title fix: increase UX of email field fix: don't capitalize first character of email field Sep 6, 2024
@chris13524 chris13524 changed the title fix: don't capitalize first character of email field fix: don't capitalize first character of email field on mobile Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-ClB9DH0L.js 1602.086 464.674
assets/noble-curves.js 31.941 12.782
assets/2.19.6_bufferutil.js 2.789 1.328
assets/index.js 9.516 3.191
assets/index2.js 102.248 29.113
assets/index3.js 304.387 87.28
assets/walletconnect-ethereum-provider.js 438.506 138.106
assets/index4.js 11.601 3.206
assets/w3m-modal.js 6.988 2.506
assets/index5.js 12.673 4.695
assets/hooks.module.js 74.437 25.583
assets/walletconnect-modal-ui.js 112.43 34.326
index.html 0.329 0.238
Total Size 2709.931 807.028

Base Size

Name Size (kb) Gzip (kb)
assets/index-ClB9DH0L.js 1602.086 464.674
assets/noble-curves.js 31.941 12.782
assets/2.19.6_bufferutil.js 2.789 1.328
assets/index.js 9.516 3.191
assets/index2.js 102.248 29.113
assets/index3.js 304.387 87.28
assets/walletconnect-ethereum-provider.js 438.506 138.106
assets/index4.js 11.601 3.206
assets/w3m-modal.js 6.988 2.506
assets/index5.js 12.673 4.695
assets/hooks.module.js 74.437 25.583
assets/walletconnect-modal-ui.js 112.43 34.326
index.html 0.329 0.238
Total Size 2709.931 807.028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants