Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose disconnect method #3254

Merged
merged 17 commits into from
Nov 19, 2024
Merged

chore: expose disconnect method #3254

merged 17 commits into from
Nov 19, 2024

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Nov 18, 2024

Description

Expose disconnect method

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes https://linear.app/reown/issue/APKT-1045/[bug]-disconnect-is-not-exposed)

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: a56c00d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:46am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:46am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:46am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:46am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:46am
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:46am

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 334.02% 4787 / 23529
🔵 Statements 334.02% 4787 / 23529
🔵 Functions 366.93% 384 / 1430
🔵 Branches 472.65% 731 / 1712
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 47.57% 69.42% 70.49% 47.57% 189-190, 233-234, 237-238, 253-256, 259-262, 265-266, 295-306, 309-318, 413, 417, 424, 462-465, 471-478, 481, 569-581, 600-603, 610-611, 619-620, 635-636, 639-640, 643-644, 647-648, 657-667, 673-680, 697-700, 709-738, 740-773, 775-779, 801-806, 808-816, 818-827, 829-849, 851-858, 860-871, 873-886, 888-891, 893-896, 898-901, 903-906, 908-915, 920-980, 983-996, 1004-1005, 1013-1124, 1130-1133, 1137-1167, 1176-1191, 1195-1197, 1201-1216, 1221-1231, 1234-1306, 1309-1323, 1326-1338, 1350, 1367, 1382-1383, 1396-1402, 1404-1415, 1417-1424, 1446-1462, 1467-1469, 1477-1481, 1496, 1510, 1512-1513, 1518-1530, 1541, 1543-1544, 1550-1561, 1568-1569, 1579, 1581, 1662, 1673-1685
Generated in workflow #7414 for commit a56c00d by the Vitest Coverage Report Action

Copy link

linear bot commented Nov 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants