-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show unsupported network UI on reconnect when chainId in wallet is not supported #3266
Conversation
🦋 Changeset detectedLatest commit: 167def5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…nsupported-network-on-reconnect
….com/reown-com/appkit into fix/unsupported-network-on-reconnect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svenvoskamp We should have been this case in wallet.spec.ts
but AFAIK through the time it got skipped and removed, if not can we add that to E2E tests as well?
We still have this in wallet.spec.ts. It shows unsupported UI when we switch to a different chain in wallet. This case is hard to test with sample wallet, because it will return an array of chains. We need E2E with browser extension to test this better IMO |
Description
Show unsupported network UI on reconnect when chainId in wallet is not supported
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist