Remove uses of the legacy react-devtools-inline package

replayio · Sep 14, 2023 · a125140 · a125140
1 parent f587dc7
commit a125140
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/src/ui/components/SecondaryToolbox/ReactDevTools.tsx b/src/ui/components/SecondaryToolbox/ReactDevTools.tsx
@@ -454,9 +454,9 @@ async function loadReactDevToolsInlineModuleFromProtocol(
   // If we don't have a version yet, it probably means we're too early in the Replay session.
   if (backendBridgeProtocolVersion >= 2) {
     stateUpdaterCallback(await import("@replayio/react-devtools-inline/frontend"));
-  } else if (backendBridgeProtocolVersion === 1) {
-    stateUpdaterCallback(await import("react-devtools-inline_4_18_0/frontend"));
   }
+  // We no longer support loading a version of `react-devtools-inline`
+  // that only knows about protocol version 1.
 }
 
 const nodePickerInstance = new NodePickerClass();

diff --git a/src/ui/components/SecondaryToolbox/react-devtools-inline.d.ts b/src/ui/components/SecondaryToolbox/react-devtools-inline.d.ts
@@ -2,10 +2,6 @@
 //   https://github.com/facebook/react/blob/main/packages/react-devtools-inline/
 //   https://github.com/facebook/react/blob/main/packages/react-devtools-shared/
 
-declare module "react-devtools-inline_4_18_0/frontend" {
-  export * from "@types/react-devtools-inline/frontend";
-}
-
 declare module "@replayio/react-devtools-inline" {
   export * from "@types/react-devtools-inline";
 }

diff --git a/src/ui/components/SecondaryToolbox/react-devtools/__tests__/rdtProcessing.test.tsx b/src/ui/components/SecondaryToolbox/react-devtools/__tests__/rdtProcessing.test.tsx
@@ -1,3 +1,4 @@
+import type { Store } from "@replayio/react-devtools-inline";
 import type { Dispatch, ReactNode, SetStateAction } from "react";
 import type { Root } from "react-dom/client";
 
@@ -21,8 +22,6 @@ import {
   TREE_OPERATION_UPDATE_TREE_BASE_DURATION,
 } from "../printOperations";
 
-import type { Store } from "@replayio/react-devtools-inline";
-
 const Component = ({ children = null }: { children?: ReactNode }) => children as any;
 
 describe("RDT processing", () => {

diff --git a/src/ui/components/SecondaryToolbox/react-devtools/injectReactDevtoolsBackend.ts b/src/ui/components/SecondaryToolbox/react-devtools/injectReactDevtoolsBackend.ts
@@ -1,8 +1,8 @@
+import type { RendererInterface } from "@replayio/react-devtools-inline";
+
 import { pauseEvaluationsCache } from "replay-next/src/suspense/PauseCache";
 import { ReplayClientInterface } from "shared/client/types";
 
-import type { RendererInterface } from "@replayio/react-devtools-inline";
-
 // Our modified RDT bundle exports some additional methods
 type RendererInterfaceWithAdditions = RendererInterface & {
   getOrGenerateFiberID: (fiber: any) => number;