Skip to content

Commit

Permalink
[RUN-3153] accept RUNTIME_BUILD_ID as an environment variable before …
Browse files Browse the repository at this point in the history
…pulling it from buildkite (#10330)

This should let us run devtools tests on any devtools branch/commit against any runtime build.


see https://linear.app/replay/issue/RUN-3153/buildkite-allow-easily-changing-devtools-versions-in-buildkite-runtime
  • Loading branch information
toshok authored Feb 16, 2024
1 parent 23dc4bd commit e547cfe
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ import run_fe_tests from "./buildkite_run_fe_tests";
export default function run_fe_tests_from_artifact(PLATFORM, ARCH) {
console.group("BUILD PREP");
console.time("BUILD PREP");
let RUNTIME_BUILD_ID = build_id_from_artifact(PLATFORM, ARCH);
let RUNTIME_BUILD_ID = process.env.RUNTIME_BUILD_ID;
if (!RUNTIME_BUILD_ID) {
RUNTIME_BUILD_ID = build_id_from_artifact(PLATFORM, ARCH);
}
let CHROME_BINARY_PATH = install_build_products(RUNTIME_BUILD_ID, PLATFORM, ARCH);
console.timeEnd("BUILD PREP");
console.groupEnd();
Expand Down

0 comments on commit e547cfe

Please sign in to comment.