Don't request an empty paint point (#10308)

replayio · Feb 13, 2024 · fb2ef3f · fb2ef3f
1 parent 6184703
commit fb2ef3f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/packages/protocol/PaintsCache.test.ts b/packages/protocol/PaintsCache.test.ts
@@ -43,17 +43,19 @@ describe("PaintsCache", () => {
   });
 
   function preCacheScreenshot(base64: string, mimeType: ScreenShot["mimeType"], data: string) {
-    screenshotCache.cache(
-      {
-        data,
-        hash: base64,
-        mimeType,
-        scale: 1,
-      },
-      null as any,
-      null as any,
-      base64
-    );
+    if (base64) {
+      screenshotCache.cache(
+        {
+          data,
+          hash: base64,
+          mimeType,
+          scale: 1,
+        },
+        null as any,
+        null as any,
+        base64
+      );
+    }
   }
 
   describe("findFirstMeaningfulPaint", () => {

diff --git a/packages/protocol/StreamingScreenShotCache.ts b/packages/protocol/StreamingScreenShotCache.ts
@@ -43,7 +43,7 @@ export const StreamingScreenShotCache = createStreamingCache<
 
     const paintPoint = findMostRecentPaint(time);
 
-    if (paintPoint) {
+    if (paintPoint && paintPoint.paintHash) {
       try {
         screenShot = await screenshotCache.readAsync(
           replayClient,
@@ -69,7 +69,7 @@ export const StreamingScreenShotCache = createStreamingCache<
       }
     }
 
-    if (executionPoint != null) {
+    if (executionPoint && executionPoint !== "0") {
       const pauseId = await pauseIdCache.readAsync(replayClient, executionPoint, time);
 
       try {