Don't reset page title after a root-level error #10405

bvaughn · 2024-03-06T18:59:58Z

I am open to other ways of doing this. I don't really like this approach, nor the way that our some of our code is currently organized so that it can't reference other parts.

I am not sure how I feel about this PR to be honest. Posting it for discussion purposes. An alternative route would be to remove this default title from the parent layout:

devtools/pages/_app.tsx

Lines 106 to 112 in ec3b9e7

    
           const MemoizedHeader = memo(function MemoizedHeader() { 
        
             return ( 
        
               <Head> 
        
                 <meta httpEquiv="Content-Type" content="text/html; charset=utf-8" /> 
        
                 <link rel="icon" type="image/svg+xml" href="/images/favicon.svg" /> 
        
                 <title>Replay</title> 
        
               </Head>

Although we would have to be sure to manually add the title to individual pages (like Library). I think I might prefer that fix.

Note to test this change I did...

diff --git a/packages/protocol/socket.ts b/packages/protocol/socket.ts
index 540701f38..e08f5fc00 100644
--- a/packages/protocol/socket.ts
+++ b/packages/protocol/socket.ts
@@ -143,7 +143,11 @@ export async function createSession(
 ) {
   const { sessionId } = await sendMessage("Recording.createSession", {
     recordingId,
-    experimentalSettings,
+    experimentalSettings: {
+      ...experimentalSettings,
+      inactivityTerminationTimeout: 0.2,
+      inactivityNotificationTimeout: 0.1,
+    },
     focusRequest: focusWindow,
   });

vercel · 2024-03-06T19:00:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
devtools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 6, 2024 7:02pm

bvaughn · 2024-03-06T19:01:47Z

src/ui/components/Errors/RootErrorDocumentTitle.tsx

+import { getRecordingId } from "shared/utils/recording";
+
+export function RootErrorDocumentTitle() {
+  const { title = "Replay" } = useGetRecordingTitle(getRecordingId());


One flaw of this is, I guess, if GraphQL goes down, our error boundary will also crash.

replay-io · 2024-03-06T19:05:09Z

E2E Tests

Status	Complete ↗︎
Commit	`cf71d17`
Results	❌ 1 Failed playwright-04: Test Step buttons and menu item (Replay 1, Replay 2, Replay 3, Replay 4) ⚠️ 1 Flaky network-01: should filter requests by type and text ✅ 108 Passed authenticated/comments-01: Test add, edit, and delete comment functionality authenticated/comments-02: Test shared comments and replies (Replay 1, Replay 2) authenticated/comments-03: Comment previews authenticated/logpoints-01: Shared logpoints functionality (Replay 1, Replay 2) authenticated/new-test-suites/tests-01: basic tests authenticated/new-test-suites/tests-02: test with no recording authenticated/new-test-suites/tests-03: test ID in the URL authenticated/passport-01: Time travel authenticated/passport-02: Infrared inspection authenticated/passport-03: Swiss army knife authenticated/passport-04: Multiplayer breakpoints-01: Test basic breakpoint functionality breakpoints-02: Test unhandled divergence while evaluating at a breakpoint breakpoints-03: Test stepping forward through breakpoints when rewound before the first one breakpoints-04: catch, finally, generators, and async/await breakpoints-05: Test interaction of breakpoints with debugger statements breakpoints-06: Test log point in a sourcemapped file breakpoints-07: rewind and seek using command bar and console messages breakpoints-08: should be temporarily disabled console_async: support console evaluations in async frames console_dock: Should show the correct docking behavior for recordings with video console_errors: Test that errors and warnings from various sources are shown in the console console_eval: support console evaluations console_warp-01: should support warping to console messages console_warp-02: support pausing, warping, stepping and evaluating console messages console-expressions-01: should cache input eager eval and terminal expressions per instance cypress-01: Basic Test Suites panel functionality cypress-02: Test Step timeline behavior cypress-03: Test Step interactions cypress-04: Test Step buttons and menu item cypress-05: Test DOM node preview on user action step hover deleted-recording: Show error message for deleted recording elements-search: Element panel should support basic and advanced search modes fe-1875 :: verify that steps go to the right point in time file-search-01: should search files focus_mode-01: should filter messages as regions based on the active focus mode highlighter: element highlighter works everywhere inspector-computed-01: Basic computed styles can be viewed inspector-elements-01: Basic DOM tree node display inspector-elements-02_node-picker: element picker and iframe behavior inspector-elements-03: Nested node picker and selection behavior inspector-elements-04: Keyboard shortcuts should select the right DOM nodes inspector-elements-05_search: element picker and iframe behavior inspector-rules-01: Basic CSS rules should be viewed inspector-rules-02: Sourcemapped rules should be viewed inspector-rules-03: Shorthand CSS rules should be viewed jump-to-code-01: Test basic jumping functionality logpoints-01: log-points appear in the correct order and allow time warping logpoints-02: conditional log-points logpoints-03: should display event properties in the console logpoints-04: should display exceptions in the console logpoints-05: should auto-complete based on log point location logpoints-06: should be temporarily disabled logpoints-07: should use the correct scope in auto-complete logpoints-08: should support jumping directly to a hit point via the capsule input logpoints-09: should support pending edits logpoints-10: too-many-points-to-find UX logpoints-11: too-many-points-to-run-analysis UX network-02: should show details for the selected request network-03: should sync and display the current time in relation to the network requests node_console_dock: Should show the correct docking behavior for recordings without video node_console-01: Basic node console behavior node_console-02: uncaught exceptions should show up node_control_flow: catch, finally, generators, and async/await node_logpoint-01: Basic node logpoints node_object_preview: Showing console objects in node node_quick_open_modal-01: Test basic searching functionality node_spawn: Basic subprocess spawning node_stepping-01: Test stepping in async frames and async call stacks node_worker-01: make sure node workers don't cause crashes object_preview-01: expressions in the console after time warping object_preview-02: should allow objects in scope to be inspected object_preview-03: Test previews when switching between frames and stepping object_preview-04: Test scope mapping and switching between generated/original sources object_preview-05: Should support logging objects as values object_preview-06: HTML elements playwright-01: Basic Test Suites panel functionality playwright-02: Test Step timeline behavior playwright-03: Test Step interactions playwright-05: Test DOM node previews on user action step hover react_devtools-01: Basic RDT behavior react_devtools-02: RDT integrations (Chromium) react_devtools-03: process and display multiple React versions in page react_devtools-04: Component selection is maintained when seeking to a new point redux_devtools: Test Redux DevTools. repaint-01: repaints the screen screen when stepping over code that modifies the DOM repaint-02: repaints on hover repaint-03: repaints on seek repaint-04: prefers nearest (<=) paint when seeking between paints repaint-05: prefers current time if pause creation failed outside of the focus window resizable-panels-01: Left side Toolbar and Video should be collapsible restart-session: restart debugging session scopes_rerender: Test that scopes are rerendered session-timeout: errors caused by session failure should bubble to the root source-line-highlights: Test source line highlighting sourcemap_stacktrace: Test that stacktraces are sourcemapped stacking: Element highlighter selects the correct element when they overlap stepping-01: Test basic step-over/back functionality stepping-02: Test fixes for some simple stepping bugs stepping-03: Stepping past the beginning or end of a frame should act like a step-out stepping-04: Test stepping in a frame other than the top frame stepping-05: Test stepping in pretty-printed code stepping-06: Test stepping in async frames and async call stacks stepping-07: Test quick stepping using the keyboard test-suite-dashboard/test-runs-01: passed run in main branch with source test-suite-dashboard/test-runs-02: failed run in temp branch without source test-suite-dashboard/test-runs-03: flaky run in main branch with source test-suite-dashboard/test-runs-04: test ID in the URL

bvaughn · 2024-03-06T19:16:42Z

Closing in favor of #10406

Don't reset page title after a root-level error

64eab6c

bvaughn requested a review from hbenl March 6, 2024 18:59

replay-soc2 bot approved these changes Mar 6, 2024

View reviewed changes

bvaughn commented Mar 6, 2024

View reviewed changes

bvaughn marked this pull request as draft March 6, 2024 19:02

vercel bot deployed to Preview March 6, 2024 19:02 View deployment

bvaughn mentioned this pull request Mar 6, 2024

Don't reset page title after a root-level error #10406

Merged

bvaughn closed this Mar 6, 2024

bvaughn deleted the FE-2041 branch March 6, 2024 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't reset page title after a root-level error #10405

Don't reset page title after a root-level error #10405

bvaughn commented Mar 6, 2024 •

edited

Loading

vercel bot commented Mar 6, 2024 •

edited

Loading

bvaughn Mar 6, 2024

replay-io bot commented Mar 6, 2024 •

edited

Loading

bvaughn commented Mar 6, 2024

	const MemoizedHeader = memo(function MemoizedHeader() {
	return (
	<Head>
	<meta httpEquiv="Content-Type" content="text/html; charset=utf-8" />
	<link rel="icon" type="image/svg+xml" href="/images/favicon.svg" />
	<title>Replay</title>
	</Head>

Don't reset page title after a root-level error #10405

Don't reset page title after a root-level error #10405

Conversation

bvaughn commented Mar 6, 2024 • edited Loading

vercel bot commented Mar 6, 2024 • edited Loading

bvaughn Mar 6, 2024

Choose a reason for hiding this comment

replay-io bot commented Mar 6, 2024 • edited Loading

E2E Tests

bvaughn commented Mar 6, 2024

bvaughn commented Mar 6, 2024 •

edited

Loading

vercel bot commented Mar 6, 2024 •

edited

Loading

replay-io bot commented Mar 6, 2024 •

edited

Loading