Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages for the most common sources of e2e flakiness #10454

Merged
merged 1 commit into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/e2e-tests/helpers/pause-information-panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ export async function waitForPaused(page: Page, line?: number): Promise<void> {
scopeBlocks.count(),
]);

expect(numFrames).toBeGreaterThan(0);
expect(numScopes).toBeGreaterThan(0);
expect(numFrames, { message: "Timed out waiting for frames" }).toBeGreaterThan(0);
expect(numScopes, { message: "Timed out waiting for scopes" }).toBeGreaterThan(0);
},
{ timeout: 15_000 }
);
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/helpers/source-panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ export async function removeBreakpoint(
// since that is not guaranteed to happen synchronously on click. This is
// important for cases where we remove a breakpoint and then immediately
// attempt to step across the breakpoint location.
await delay(500);
await delay(1000);
}

export async function removeConditional(
Expand Down Expand Up @@ -849,7 +849,7 @@ export async function waitForSelectedSource(page: Page, url: string) {
// Only succeed when we see formatted lines.
const lines = editorPanel.locator(`[data-test-formatted-source="true"]`);
const numLines = await lines.count();
expect(numLines).toBeGreaterThan(0);
expect(numLines, { message: "Timed out waiting for source contents" }).toBeGreaterThan(0);
});
}

Expand Down
Loading