Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed snapshot uploads #9712

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Retry failed snapshot uploads #9712

merged 1 commit into from
Sep 11, 2023

Conversation

hbenl
Copy link
Contributor

@hbenl hbenl commented Sep 8, 2023

Remove process.exit(1) from uploadSnapshot() and throw instead - the caller of uploadSnapshot() will retry and process.exit(1) itself if the second attempt fails.

@hbenl hbenl self-assigned this Sep 8, 2023
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devtools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 1:17pm

@replay-io
Copy link

replay-io bot commented Sep 8, 2023

E2E Tests

79 replays were recorded for ff656da.

image 0 Failed
image 79 Passed

View test run on Replay ↗︎

Snapshot Tests

100 replays were recorded for ff656da.

image 1 Failed
image 99 Passed

View test run on Replay ↗︎

@replay-delta
Copy link

replay-delta bot commented Sep 11, 2023

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants