improve comments

Signed-off-by: technillogue <technillogue@gmail.com>

pkg/config/config.go

@@ -50,11 +50,11 @@ type Example struct {
 }
 
 type Config struct {
-	Build   *Build `json:"build" yaml:"build"`
-	Image   string `json:"image,omitempty" yaml:"image"`
-	Predict string `json:"predict,omitempty" yaml:"predict"`
-	Train   string `json:"train,omitempty" yaml:"train"`
-    Concurrency int `json:"concurrency,omitempty" yaml:"concurrency"`
+	Build       *Build `json:"build" yaml:"build"`
+	Image       string `json:"image,omitempty" yaml:"image"`
+	Predict     string `json:"predict,omitempty" yaml:"predict"`
+	Train       string `json:"train,omitempty" yaml:"train"`
+	Concurrency int    `json:"concurrency,omitempty" yaml:"concurrency"`
 }
 
 func DefaultConfig() *Config {

pkg/config/validator.go

@@ -99,7 +99,6 @@ func getDescription(err validationError) string {
 		}
 		return err.child.Description()
 	}
-	fmt.Printf("err.parent.Description(): %s\n", err.parent.Description())
 	return err.parent.Description()
 }
 

python/cog/predictor.py

@@ -89,8 +89,9 @@ def get_weights_argument(predictor: BasePredictor) -> Union[CogFile, CogPath, st
     # up a little bit.
     # TODO: CogFile/CogPath should have subclasses for each of the subtypes
 
-
-    # trt has Path... so it's like expecting it to be downloaded...?
+    # this is a breaking change
+    # previously, CogPath wouldn't be converted; now it is
+    # essentially everyone needs to switch from Path to str (or a new URL type)
     if weights_url:
         if weights_type == CogFile:
             return cast(CogFile, CogFile.validate(weights_url))
@@ -217,17 +218,21 @@ def cleanup(self) -> None:
             # # Handle URLPath objects specially for cleanup.
             # if isinstance(value, URLPath):
             #     value.unlink()
-            # Note this is pathlib.Path, which cog.Path is a subclass of. A pathlib.Path object shouldn't make its way here,
+            # Note this is pathlib.Path, of which cog.Path is a subclass of.
+            # A pathlib.Path object shouldn't make its way here,
             # but both have an unlink() method, so may as well be safe.
             #
-            # URLThatCanBeConvertedToPath, DataURLTempFilePath, pathlib.Path, doesn't matter
+            # URLTempFile, DataURLTempFilePath, pathlib.Path, doesn't matter
             # everyone can be unlinked
             if isinstance(value, Path):
                 try:
                     value.unlink()
                 except FileNotFoundError:
                     pass
 
+    # if we had a separate method to traverse the input and apply some function to each value
+    # we could use something like these functions here
+
     # def cleanup():
     #     if isinstance(value, Path):
     #         value.unlink()

python/cog/server/clients.py

@@ -83,11 +83,12 @@ def httpx_file_client() -> httpx.AsyncClient:
     # requests has no write timeout, keep that
     # httpx default for pool is 5, use that
     timeout = httpx.Timeout(connect=10, read=15, write=None, pool=5)
+    # verify: Union[str, bool, ssl.SSLContext] = True,
     return httpx.AsyncClient(
         transport=transport,
         follow_redirects=True,
         timeout=timeout,
-        verify=os.environ.get("CURL_CA_BUNDLE"),
+        verify=os.environ.get("CURL_CA_BUNDLE", True),
     )
 
 
@@ -197,13 +198,13 @@ async def chunk_file_reader() -> AsyncIterator[bytes]:
     async def upload_files(self, obj: Any, url: Optional[str]) -> Any:
         """
         Iterates through an object from make_encodeable and uploads any files.
-
         When a file is encountered, it will be passed to upload_file. Any paths will be opened and converted to files.
         """
         # # it would be kind of cleaner to make the default file_url
         # # instead of skipping entirely, we need to convert to datauri
         # if url is None:
         #     return obj
+        # TODO: upload concurrently
         if isinstance(obj, dict):
             return {
                 key: await self.upload_files(value, url) for key, value in obj.items()

python/cog/types.py

@@ -149,6 +149,7 @@ def __str__(self) -> str:
         # FastAPI's jsonable_encoder will encode subclasses of pathlib.Path by
         # calling str() on them
         return self.filename
+        # honestly maybe returning self.url would be safer
 
     def unlink(self, missing_ok: bool = False) -> None:
         if self._path:

python/tests/server/test_http.py

@@ -395,15 +395,6 @@ def test_train_openapi_specification(client):
     }
 
 
-@uses_predictor("async_yield")
-def test_yielding_strings_from_async_generator_predictors(client, match):
-    resp = client.post("/predictions")
-    assert resp.status_code == 200
-    assert resp.json() == match(
-        {"status": "succeeded", "output": ["foo", "bar", "baz"]}
-    )
-
-
 @uses_predictor("yield_strings")
 def test_yielding_strings_from_generator_predictors(client, match):
     resp = client.post("/predictions")