Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple PredictionEventHandler #1392

Closed
wants to merge 6 commits into from
Closed

multiple PredictionEventHandler #1392

wants to merge 6 commits into from

Commits on Nov 28, 2023

  1. Revert "Revert "support async predict functions (#1350)" (#1373)" 

    This reverts commit f60abe3.

Signed-off-by: technillogue <technillogue@gmail.com>
    @technillogue
    technillogue committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    47f3fa5 View commit details
    Browse the repository at this point in the history

  2. conditionally create the event loop if predictor is async, and add a … 

    …path for hypothetical async setup

this may be appealing if your setup uses async heavily for e.g. downloading weights and also doing something else

Signed-off-by: technillogue <technillogue@gmail.com>
    @technillogue
    technillogue committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    dcf5ac4 View commit details
    Browse the repository at this point in the history

  3. don't use async for predict loop if predict is not async 

    Signed-off-by: technillogue <technillogue@gmail.com>
    @technillogue
    technillogue committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8b8bbac View commit details
    Browse the repository at this point in the history

  4. add test cases for shared loop across setup and predict + asyncio.run… 

    … in setup

running the worker tests individually is always fine, but sometimes when running the full suite the same loop test throws "Unreliable test timings! On an initial run, this test took 652.54ms, which exceeded the deadline of 500.00ms, but on a subsequent run it took 346.94 ms"

Signed-off-by: technillogue <technillogue@gmail.com>
    @technillogue
    technillogue committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0ca5521 View commit details
    Browse the repository at this point in the history

  5. move runner.predict into PredictionRunner._predict 

    Signed-off-by: technillogue <technillogue@gmail.com>
    @technillogue
    technillogue committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    573e318 View commit details
    Browse the repository at this point in the history

  6. bad wip 

    Signed-off-by: technillogue <technillogue@gmail.com>
    @technillogue
    technillogue committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6bac76a View commit details
    Browse the repository at this point in the history