-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Secret
type
#1546
Merged
Merged
Define Secret
type
#1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/secrets
branch
3 times, most recently
from
February 24, 2024 11:14
3ae5d52
to
2c1f02c
Compare
what I really like about this is that it gives us to flexibility to potentially only redact and not store prediction secrets |
technillogue
approved these changes
Mar 28, 2024
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
added a commit
that referenced
this pull request
May 31, 2024
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
added a commit
that referenced
this pull request
May 31, 2024
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
added a commit
that referenced
this pull request
May 31, 2024
* Define Secret type (#1546) Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Fix linter errors (#1691) * ruff --fix Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff pyproject settings Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff lint command in Makefile Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Run ruff --fix python Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com>
technillogue
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Define Secret type (#1546) Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Fix linter errors (#1691) * ruff --fix Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff pyproject settings Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff lint command in Makefile Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Run ruff --fix python Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com>
technillogue
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Define Secret type (#1546) Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Fix linter errors (#1691) * ruff --fix Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff pyproject settings Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff lint command in Makefile Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Run ruff --fix python Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com> Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Define Secret type (#1546) Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Fix linter errors (#1691) * ruff --fix Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff pyproject settings Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update ruff lint command in Makefile Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Run ruff --fix python Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com> Signed-off-by: technillogue <technillogue@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a new
Secret
type in Cog's Python package, which model authors can use to signify that an input holds sensitive information (like a password or API token).The
Secret
type inherits from Pydantic'sSecretStr
:A predictor's
Secret
inputs are represented in OpenAPI with the following schema:Replicate will treat secret inputs differently throughout its system. For example, a prediction on Replicate will redact secret values in its JSON representation and log lines.