Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for Apple Silicon M1 support in run #1704

Merged
merged 2 commits into from
May 31, 2024

Conversation

timfallmk
Copy link
Contributor

This commit fixes the run command for Apple Silicon M1 support. The run command now uses the docker run command with the --platform flag set to linux/amd64 to ensure that the container runs on the correct architecture. This behavior matches the build command, which also uses the --platform flag to ensure that the image is built for the correct architecture.

This commit fixes the `run` command for Apple Silicon M1 support. The `run` command now uses the `docker run` command with the `--platform` flag set to `linux/amd64` to ensure that the container runs on the correct architecture.
This behavior matches the `build` command, which also uses the `--platform` flag to ensure that the image is built for the correct architecture.
Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @timfallmk!

@mattt mattt merged commit a749228 into main May 31, 2024
15 checks passed
@mattt mattt deleted the tf/apple-silicon-platform-run branch May 31, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants