Deduplicate choices #1994
Draft
Deduplicate choices #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballhat
approved these changes
Oct 15, 2024
tempusfrangit
force-pushed
the
de-dupe-choices
branch
from
c149092
to
46c61f0
Compare
Ensure choices are not duplicated, as that makes StrEnum impossible to resolve. Each element should only exist once. The deduplicate must be done at the schema level and therefore a decorator is utilized to mutate duplicated choices passed to Input().
tempusfrangit
force-pushed
the
de-dupe-choices
branch
from
46c61f0
to
5078634
Compare
|
Not exactly sure why python 3.12 fails with pydantic 1. Clearly something is super wonky since other python versions succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure choices are not duplicated, as that makes StrEnum impossible to resolve. Each element should only exist once.