Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Print runPod collector name in failed error logs #4848

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

5hubh49
Copy link
Member

@5hubh49 5hubh49 commented Aug 27, 2024

What this PR does / why we need it:

Requirement to include the collector name print in the error logs. See story #109476

Screenshot 2024-08-27 at 10 56 51 PM

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

NONE


Does this PR require documentation?

NONE

@5hubh49 5hubh49 added the type::feature New feature or request label Aug 27, 2024
@5hubh49 5hubh49 requested a review from xavpaice August 27, 2024 17:30
Copy link
Member

@xavpaice xavpaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs approval from someone in the Installers team.

@5hubh49 5hubh49 merged commit 46ea0ce into main Aug 29, 2024
144 checks passed
@5hubh49 5hubh49 deleted the collector-name-task branch August 29, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants