Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow end users to configure additional trusted certificate authorities #4884

Merged

Conversation

laverya
Copy link
Member

@laverya laverya commented Sep 12, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

Adds a new flag `--private-ca-configmap` to the `install` and `generate-manifests` commands. The provided configmap's contents will be used as additional certificate authority certificates.

Does this PR require documentation?

@laverya laverya added the type::feature New feature or request label Sep 12, 2024
@laverya laverya marked this pull request as ready for review September 13, 2024 16:22
emosbaugh
emosbaugh previously approved these changes Sep 13, 2024
@@ -73,6 +73,7 @@ func AdminGenerateManifestsCmd() *cobra.Command {
IsOpenShift: isOpenShift,
IsGKEAutopilot: isGKEAutopilot,
RegistryConfig: registryConfig,
TrustedCAsConfigmap: v.GetString("private-ca-configmap"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the naming inconsistency? how about:

Suggested change
TrustedCAsConfigmap: v.GetString("private-ca-configmap"),
PrivateCAsConfigmap: v.GetString("private-ca-configmap"),

sgalsaleh
sgalsaleh previously approved these changes Sep 13, 2024
@laverya laverya dismissed stale reviews from sgalsaleh and emosbaugh via cb48ec7 September 13, 2024 17:39
@laverya laverya enabled auto-merge (squash) September 13, 2024 17:39
@laverya laverya merged commit 866184c into main Sep 13, 2024
118 checks passed
@laverya laverya deleted the laverya/sc-75216/allow-end-users-to-configure-additional-trusted branch September 13, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants