allow end users to configure additional trusted certificate authorities #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-additional-trusted
…e-additional-trusted
emosbaugh
previously approved these changes
Sep 13, 2024
sgalsaleh
reviewed
Sep 13, 2024
| @@ -73,6 +73,7 @@ func AdminGenerateManifestsCmd() *cobra.Command { | |||
| IsOpenShift: isOpenShift, | |||
| IsGKEAutopilot: isGKEAutopilot, | |||
| RegistryConfig: registryConfig, | |||
| TrustedCAsConfigmap: v.GetString("private-ca-configmap"), | |||
There was a problem hiding this comment.
why the naming inconsistency? how about:
Suggested change
| TrustedCAsConfigmap: v.GetString("private-ca-configmap"), | |
| PrivateCAsConfigmap: v.GetString("private-ca-configmap"), |
sgalsaleh
previously approved these changes
Sep 13, 2024
sgalsaleh
approved these changes
Sep 13, 2024
laverya
deleted the
laverya/sc-75216/allow-end-users-to-configure-additional-trusted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?