WIP: allow host collector progress in kots #4963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,3 +51,26 @@ func LoadTSKindsFromPath(dir string) (*troubleshootloader.TroubleshootKinds, err | |||
| } | |||
| return tsKinds, nil | |||
| } | |||
|
|
|||
| func Dedup[T any](objs []T) []T { | |||
There was a problem hiding this comment.
Reconsider the implementation of Dedup. Instead of using JSON marshaling to check for duplicates, consider if there's a simpler way that takes advantage of the properties of the objects you're working with (e.g., unique fields or a specific interface method). This will improve the performance and clarity of the code.
There was a problem hiding this comment.
Thank you! I will close this PR and update the change in #4958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prerequisite PR:
demo: Library | Loom - 24 October 2024 - Watch Video
Which issue(s) this PR fixes:
sc-114419
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?