Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Install goldpinger daemonset if one does not exist when running goldpinger collector #1619

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat: Install goldpinger daemonset if one does not exist when running goldpinger collector #1619

merged 3 commits into from
Sep 24, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Sep 23, 2024 •
edited
Loading

Description, Motivation and Context

  • Deploy golpinger daemonset if one is not detected in the cluster
  • Clean up all deployed resources
  • Add delay to allow users to wait for goldpinger to perform checks

A sample spec would look like this

apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  name: goldpinger
spec:
  collectors:
    - goldpinger:
        namespace: default
        collectDelay: 10s
  analyzers:
    - goldpinger: {}

Fixes: sc-112399

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh banjoh requested a review from a team as a code owner September 23, 2024 15:32
@banjoh banjoh marked this pull request as draft September 23, 2024 15:32
@banjoh
feat: Install goldpinger if one does not exist when running goldpinge…
fd6e536 
…r collector

- Deploy golpinger daemonset if one is not detected in the cluster
- Clean up all deployed resources
- Add delay to allow users to wait for goldpinger to perform checks

Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh force-pushed the evansmungai/sc-112399/check-network-connectivity-between-nodes branch from 498f06e to fd6e536 Compare September 24, 2024 09:24
@banjoh banjoh marked this pull request as ready for review September 24, 2024 09:26
@banjoh
Add missing test data file
af22959 
Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh added the type::feature New feature or request label Sep 24, 2024
hedge-sparrow
hedge-sparrow previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@hedge-sparrow hedge-sparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick that the create resource functions aren't consistently named, but LGTM

@banjoh
Better naming of create resource functions
0d356c6 
Signed-off-by: Evans Mungai <evans@replicated.com>
hedge-sparrow
hedge-sparrow approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@hedge-sparrow hedge-sparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@banjoh banjoh merged commit 83f02f4 into replicatedhq:main Sep 24, 2024
27 checks passed
@banjoh banjoh deleted the evansmungai/sc-112399/check-network-connectivity-between-nodes branch September 24, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedge-sparrow hedge-sparrow hedge-sparrow approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banjoh @hedge-sparrow