feat: allow to specify dial interface #1622
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default the tcp port status collector listen on all interfaces but
selects the first interface found to issue the request. this commit
makes the collector to accept an interface to which we want to call.
for example:
```yaml
collectors:
- tcpPortStatus:
collectorName: test
port: 10248
dialInterface: lo
```
this definition will make the collector listen on all interface but call
127.0.0.1:10248 to test. other example could be:
```yaml
collectors:
- tcpPortStatus:
collectorName: test
port: 10248
dialInterface: eth0
```
this again will make the collector listen in all interfaces but it will
use the ip found on eth0 to issue the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
by default the tcp port status collector listen on all interfaces but selects the first interface found to issue the request. this commit makes the collector to accept an interface to which it should call.
for example:
this definition will make the collector listen on all interface but call 127.0.0.1:10248 to test. other example could be:
this again will make the collector listen in all interfaces but it will use the ip found on eth0 to issue the call.
Checklist
Does this PR introduce a breaking change?