Don't run build workflow for tagged commits on main #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeichestakov
requested review from
szymonkaliski,
a team and
ltazmin
and removed request for
a team
ltazmin
reviewed
Oct 16, 2023
ltazmin
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We don't need to run this job for tagged commits to main (i.e. releases) since we already run the publish workflow which basically does a superset of the same thing (minus lint) which makes this redundant.
What changed
Don't run build workflow for tagged commits on main
Test plan
Next time we publish we should only see the publish workflow run instead of both publish and build