Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate splash screen and full screen windows #71

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

sergeichestakov
Copy link
Contributor

@sergeichestakov sergeichestakov commented Jul 17, 2023

Why

As part of the home page redesign (see Figma mocks), we want to get rid of the concept of the "splash screen" after much user feedback and consolidate it with the "full window" previously only used by the workspace into one resizable window.

Note that we need to land some web changes before shipping this (e.g. new redirect logic to point to the new home screen) but wanted to get the native changes up in the meantime.

What changed

Consolidate splash screen and full screen windows into one window and update naming as a result

Test plan

  • Open App
  • Auth screen and home page open in the resizable full window
  • Everything else works as expected (opening Repls, create new window shortcut, etc)

Copy link
Member

@szymonkaliski szymonkaliski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

src/ipc.ts Outdated Show resolved Hide resolved
@sergeichestakov sergeichestakov merged commit e23b669 into main Jul 20, 2023
4 checks passed
@sergeichestakov sergeichestakov deleted the @sergeichestakov/rm-splash-screen branch July 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants