Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative URL support in createWindow #74

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Relative URL support in createWindow #74

merged 1 commit into from
Jul 24, 2023

Conversation

sergeichestakov
Copy link
Contributor

Why

Similar to https://github.com/replit/repl-it-web/pull/32881/ but for the createWindow API. think it's convenient to support relative URLs.

What changed

Add relative URL support in createWindow API

Test plan

  • Pass in a relative URL e.g. /about -> see replit.com/about
  • Don't pass in any URL -> still works as expected by loading in the home page

@sergeichestakov sergeichestakov self-assigned this Jul 21, 2023
@sergeichestakov sergeichestakov merged commit 01598f3 into main Jul 24, 2023
4 checks passed
@sergeichestakov sergeichestakov deleted the @sergeichestakov/relative-url branch July 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymonkaliski szymonkaliski szymonkaliski approved these changes

Assignees

@sergeichestakov sergeichestakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeichestakov @szymonkaliski