Composer V2 Support #100
Composer V2 Support #100
Conversation
|
@akondas Done plenty of tests in about 10 differents projects, for a total of 1600 installs. I think this is ready to get merged. FYI, Repman and Composer V2 are incredebly fast ! Our update time went from about 5-10 minutes to about 30 seconds ! ❤️ |
|
I'm very happy about this. And thank you very much for your time spent on work. |
|
Could you enable the "Allow edits from maintainers." option. I would add tests and we could merge. |
|
@akondas No clue where is the option |
| @@ -5,6 +5,7 @@ | |||
| # https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration | |||
| parameters: | |||
| package_name_pattern: '[A-Za-z0-9_.-]+/[A-Za-z0-9_./-]+?' | |||
| package_name_pattern_v2: '[A-Za-z0-9_.-]+/[A-Za-z0-9_./~-]+?' | |||
There was a problem hiding this comment.
You need to be able to pass through dev packages, and they contain a ~
There was a problem hiding this comment.
I guess you could merge it in the previous pattern, but i wanted to make it obvious
| return Option::none(); | ||
| } | ||
|
|
||
| return $this->metadataProvider->fromUrl($this->getUrl($providerPath->get())); |
There was a problem hiding this comment.
We will probably need to do it differently, in this case we will overwrite the v1 data with the v2 version.
If I find a moment, I can finish it, but currently I am still involved in something else, if you would like to finish it yourself, I suggest you do it through an additional parameter and save the data in a separate directory p2
|
Thanks @sadortun for help. @karniv00l created complete support for v2 based on your work. I will add your name to changelog. We didn't want to do it in this PR so as not to waste your time. If we can do something more, let me know. Thanks again 👏 |
Added support for Composer V2. Currently testing....
Todo
metadata-urlproviders-api(optional)V2 is just incretibly faster ! Its amaizing !