Implement telemetry #234
Merged
Implement telemetry #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akondas
reviewed
Jul 23, 2020
akondas
reviewed
Jul 23, 2020
akondas
reviewed
Jul 23, 2020
akondas
reviewed
Jul 23, 2020
akondas
reviewed
Jul 23, 2020
akondas
reviewed
Jul 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
============================================
+ Coverage 99.65% 99.67% +0.01%
- Complexity 1422 1481 +59
============================================
Files 235 245 +10
Lines 4088 4318 +230
============================================
+ Hits 4074 4304 +230
Misses 14 14
Continue to review full report at Codecov.
|
akondas
reviewed
Jul 24, 2020
| FROM "organization" o | ||
| LEFT JOIN "organization_token" t ON t.organization_id = o.id | ||
| LEFT JOIN "organization_member" m ON m.organization_id = o.id AND m.role = :role_member | ||
| LEFT JOIN "organization_member" ow ON ow.organization_id = o.id AND ow.role = :role_owner |
There was a problem hiding this comment.
This double join can be avoided with FILTER 😎
COUNT(m.id) FILTER (WHERE m.role = :role_member) AS members,
COUNT(m.id) FILTER (WHERE m.role = :role_owner) AS ownerscheck this please, I'm not sure 😉
akondas
reviewed
Jul 24, 2020
| COUNT(d.id) downloads, | ||
| COUNT(w.date) webhooks | ||
| FROM "organization_package" p | ||
| LEFT JOIN "organization_package_download" d ON d.package_id = p.id |
There was a problem hiding this comment.
missing AND d.date::date <= :till
akondas
reviewed
Jul 24, 2020
akondas
reviewed
Jul 24, 2020
akondas
reviewed
Jul 24, 2020
| ] | ||
| ); | ||
|
|
||
| if ($response->getStatusCode() >= 300) { |
There was a problem hiding this comment.
why 300? (I thought this client dealt with redirects) Maybe 400?
akondas
reviewed
Jul 24, 2020
akondas
reviewed
Jul 24, 2020
akondas
reviewed
Jul 24, 2020
akondas
reviewed
Jul 24, 2020
akondas
approved these changes
Jul 24, 2020
* Implement telemetry * Show telemetry documentation link
karniv00l
force-pushed
the
telemetry-rebased
branch
from
42a736d
to
5b999ee
Compare
|
Thanks 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is full PR to master, I've rebased so I could use new Proxy service