Set packages.json last modified based on a provider-latest timestamp #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akondas
reviewed
Sep 23, 2020
src/Controller/ProxyController.php
Outdated
| @@ -54,12 +54,15 @@ public function packages(Request $request): JsonResponse | |||
| ], | |||
| ], | |||
| 'providers-lazy-url' => '/p/%package%', | |||
| 'provider-includes' => $providerHash !== null ? ['p/provider-latest$%hash%.json' => ['sha256' => $providerHash]] : [], | |||
| 'provider-includes' => $metadata->isPresent() === true ? ['p/provider-latest$%hash%.json' => ['sha256' => $metadata->get()->hash()]] : [], | |||
There was a problem hiding this comment.
$metadata->isPresent() === true why not just $metadata->isPresent()
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=========================================
Coverage 99.68% 99.68%
- Complexity 1818 1823 +5
=========================================
Files 284 284
Lines 5325 5334 +9
=========================================
+ Hits 5308 5317 +9
Misses 17 17
Continue to review full report at Codecov.
|
akondas
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.