-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display README.md for packages #303
Conversation
Extract the file from the latest release dist zip, and store rendered in the database.
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
============================================
- Coverage 99.54% 99.48% -0.06%
+ Complexity 2077 1939 -138
============================================
Files 295 295
Lines 5973 5684 -289
============================================
- Hits 5946 5655 -291
- Misses 27 29 +2
Continue to review full report at Codecov.
|
I'll work on the tests, then it'll be ready for review. |
This holds the extra information required for the Package Details page (README)
The number of release restrictions is affecting how this works. At the moment, the latest version won't necessarily be in the list of available versions. I think that it should always be in that list. |
Fixes #306 by sorting the packages before picking the latest version.
src/Service/PackageSynchronizer/ComposerPackageSynchronizer.php
Outdated
Show resolved
Hide resolved
tests/Unit/Service/PackageSynchronizer/ReadmeComposerPackageSynchronizerTest.php
Show resolved
Hide resolved
Functionality is already the same
Thanks @giggsey, will you resolve the conflict with the master also? |
* repman-io/master: Update doctrine-bundle and symfony to remove deprecation notice (#305)
Ignore that last commit, I think the merge went bad. I'll also downgrade my composer back to v1 to do this |
This reverts commit 8f3970f.
That ad4b80a was actually fine, but I've done that update again using Composer v1. Should be ready now @karniv00l |
Good job @giggsey 🍺 |
Thanks for merging. I go back to work tomorrow after paternity leave, so I should be leaving you guys in peace for a bit ;) |
Extract the file from the latest release dist zip, and store rendered in the database.
Part of #175