Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display README.md for packages #303

Merged
merged 15 commits into from
Oct 20, 2020
Merged

Display README.md for packages #303

merged 15 commits into from
Oct 20, 2020

Conversation

giggsey
Copy link
Contributor

@giggsey giggsey commented Oct 15, 2020

Extract the file from the latest release dist zip, and store rendered in the database.

image

Part of #175

Extract the file from the latest release dist zip, and store rendered in the database.
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #303 into master will decrease coverage by 0.05%.
The diff coverage is 93.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
- Coverage     99.54%   99.48%   -0.06%     
+ Complexity     2077     1939     -138     
============================================
  Files           295      295              
  Lines          5973     5684     -289     
============================================
- Hits           5946     5655     -291     
- Misses           27       29       +2     
Impacted Files Coverage Δ Complexity Δ
src/Query/User/Model/Package.php 100.00% <ø> (ø) 31.00 <0.00> (-45.00)
src/Query/User/PackageQuery/DbalPackageQuery.php 96.20% <76.00%> (-1.33%) 32.00 <5.00> (-17.00)
...ackageSynchronizer/ComposerPackageSynchronizer.php 98.13% <85.71%> (-1.87%) 30.00 <0.00> (-22.00)
src/Controller/OrganizationController.php 100.00% <100.00%> (ø) 40.00 <1.00> (-40.00)
src/Entity/Organization/Package.php 100.00% <100.00%> (ø) 42.00 <4.00> (-14.00)
src/Query/User/Model/PackageDetails.php 100.00% <100.00%> (ø) 25.00 <25.00> (ø)
src/Query/User/Model/PackageScanResultTrait.php 100.00% <100.00%> (ø) 14.00 <14.00> (ø)
...vice/Organization/PackageDetailsParamConverter.php 100.00% <100.00%> (ø) 6.00 <6.00> (ø)
src/Service/ReadmeExtractor.php 100.00% <100.00%> (ø) 7.00 <7.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3359d2...8209e98. Read the comment docs.

@giggsey
Copy link
Contributor Author

giggsey commented Oct 15, 2020

I'll work on the tests, then it'll be ready for review.

@giggsey giggsey marked this pull request as ready for review October 18, 2020 12:48
@giggsey
Copy link
Contributor Author

giggsey commented Oct 18, 2020

The number of release restrictions is affecting how this works.

At the moment, the latest version won't necessarily be in the list of available versions. I think that it should always be in that list.

Fixes #306 by sorting the packages before picking the latest version.
* origin/readme:
  Add list of 3rd party software licences (#304)
  Do not allow null values for number of last releases when updating (#302)
@giggsey giggsey requested a review from akondas October 18, 2020 17:56
src/Service/Markdown.php Outdated Show resolved Hide resolved
Functionality is already the same
@karniv00l
Copy link
Contributor

Thanks @giggsey, will you resolve the conflict with the master also?

* repman-io/master:
  Update doctrine-bundle and symfony to remove deprecation notice (#305)
@giggsey
Copy link
Contributor Author

giggsey commented Oct 20, 2020

Ignore that last commit, I think the merge went bad.

I'll also downgrade my composer back to v1 to do this

@giggsey
Copy link
Contributor Author

giggsey commented Oct 20, 2020

That composer update did not go well...

ad4b80a was actually fine, but I've done that update again using Composer v1.

Should be ready now @karniv00l

@karniv00l karniv00l merged commit 63d5625 into repman-io:master Oct 20, 2020
@karniv00l
Copy link
Contributor

Good job @giggsey 🍺

@giggsey
Copy link
Contributor Author

giggsey commented Oct 20, 2020

Thanks for merging.

I go back to work tomorrow after paternity leave, so I should be leaving you guys in peace for a bit ;)

@giggsey giggsey deleted the readme branch October 20, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants