Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test compatibility issues and small deprecation fix #414

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

pedro-stanaka
Copy link
Contributor

Hey guys, I stumbled upon a couple of problems while running the tests on docker (with alpine images), so I wanted to make this little change to make tests behavior better on newer versions of git and different linux distros.

Also, the factory method for Config from phpcs has been deprecated, I took time to fix that as well.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #414 (58acce9) into master (f34f997) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #414   +/-   ##
=========================================
  Coverage     99.38%   99.38%           
  Complexity     1863     1863           
=========================================
  Files           297      297           
  Lines          5871     5871           
=========================================
  Hits           5835     5835           
  Misses           36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34f997...58acce9. Read the comment docs.

Copy link
Member

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@akondas akondas merged commit fb5e744 into repman-io:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants