Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard loading empty if base URL is given #1468

Closed
damithc opened this issue Mar 7, 2021 · 7 comments · Fixed by #1469
Closed

Dashboard loading empty if base URL is given #1468

damithc opened this issue Mar 7, 2021 · 7 comments · Fixed by #1469
Labels
c.Bug p.High

Comments

@damithc
Copy link
Collaborator

damithc commented Mar 7, 2021

Any idea why https://nus-cs3281.github.io/2021-dashboard is loading empty? The data shows up only if I click on the 'reset date' button

image

Any recent change to URL parameters that could have caused this?
@fzdy1914
Copy link
Member

fzdy1914 commented Mar 7, 2021

@gerhean Can you check this one? It may cause by the only filter once PR or the use computed since date PR?

@fzdy1914
Copy link
Member

fzdy1914 commented Mar 7, 2021

Error warning.
image

@damithc
Copy link
Collaborator Author

damithc commented Mar 7, 2021

Other things don't work too. e.g., can't load the code view. Need to locate the problematic PR and revert to quickly as all modules are using the latest version of RepoSense.

@gerhean
Copy link
Contributor

gerhean commented Mar 7, 2021

This is a regression by #1421,
Ill try to fix by today.

@gerhean gerhean mentioned this issue Mar 7, 2021
Merged
@damithc
Copy link
Collaborator Author

damithc commented Mar 7, 2021

This is a regression by #1421,

@fzdy1914 can you revert the PR for the time being?

@damithc
Copy link
Collaborator Author

damithc commented Mar 8, 2021

It doesn't seem to some dashboards though e.g., https://nus-tic4002-ay2021s2.github.io/ip-dashboard/

@fzdy1914
Copy link
Member

fzdy1914 commented Mar 8, 2021

@damithc, gerhean have identified the issue. I will merge his fix quickly.

fzdy1914 pushed a commit that referenced this issue Mar 8, 2021
@gerhean
[#1468] Dashboard loading empty if base URL is given (#1469)
3973bf0 
Repositories with more than 19 different types of files will crash,
which can be traced from line 448 of `v_summary.js`.

Bug is caused by a function not being copied properly in #1421,
leading to an undefined function call.

Let's copy the function over properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Bug p.High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1468] Dashboard loading empty if base URL is given gerhean/RepoSense
3 participants
@damithc @gerhean @fzdy1914