Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2220] Empty cell in UG #2234

Merged
merged 5 commits into from
Jul 27, 2024
Merged

[#2220] Empty cell in UG #2234

merged 5 commits into from
Jul 27, 2024

Conversation

logical-1985516
Copy link
Contributor

Fixes #2220

Proposed commit message

As branches are already specified in the first cell, the 2nd cell
specifying the branch may only confuse the user.

Let's remove the contents of the second cell.

Other information

Due to intellij recognizing a pipe operator as a column separator, the preview looks different compared to the rendering on github.
Before:
image
After:
image

jonasongg
jonasongg approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@jonasongg jonasongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasongg jonasongg requested a review from a team July 6, 2024 12:03
jedkohjk
jedkohjk approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@jedkohjk jedkohjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Though I think only one line has to be changed and not 3? But this works too!)

ckcherry23
ckcherry23 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 merged commit 402f40e into reposense:master Jul 27, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@jedkohjk jedkohjk jedkohjk approved these changes

@jonasongg jonasongg jonasongg approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible typo in UG
4 participants
@logical-1985516 @ckcherry23 @jedkohjk @jonasongg