Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2240] Format datetime #2242

Merged
merged 2 commits into from
Aug 3, 2024
Merged

[#2240] Format datetime #2242

merged 2 commits into from
Aug 3, 2024

Conversation

jedkohjk
Copy link
Contributor

@jedkohjk jedkohjk commented Jul 28, 2024

Resolves #2240

Proposed commit message

Format datetime as "day date month year time timezone"

Before, it was "day month date time year timezone".

"day date month year time timezone" puts the year with the rest of 
the date, and puts the time with the timezone, which is more 
intuitive.

Using "date month year" instead of putting the month before the date 
keeps the date format consistent with the since and until dates, and 
is also the norm in most of Singapore.

Other information

Before:

Before

After:

After

Copy link
Contributor

@jonasongg jonasongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasongg jonasongg assigned jonasongg and unassigned jonasongg Aug 2, 2024
@jonasongg jonasongg requested a review from a team August 2, 2024 11:31
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jedkohjk jedkohjk changed the title Format datetime [#2240] Format datetime Aug 3, 2024
@ckcherry23 ckcherry23 merged commit bf162ca into reposense:master Aug 3, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Aug 3, 2024

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update report generation datetime format
3 participants