Dispose TestThread-Container correctly (#135)

* Dispose TestThread-Container correctly * use _testRunnerRegistry directly to access test thread containers, add unit test * undo system tests * cleanup TestRunnerManagerTests * cleanup TestRunnerManager --------- Co-authored-by: Gáspár Nagy <gaspar.nagy@gmail.com>
reqnroll · May 22, 2024 · 3ae913a · 3ae913a
1 parent 5257abd
commit 3ae913a
Show file tree

Hide file tree

Showing 7 changed files with 294 additions and 270 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@
 * Fix: StackOverflowException when using `[StepArgumentTransformation]` with same input and output type, for example string (#71)
 * Fix: Autofac without hook does not run GlobalDependencies (#127)
 * Fix: Reqnroll.Autofac shows wrongly ambiguous step definition (#56)
+* Fix: Dispose objects registred in test thread container at the end of test execution (#123)
 
 # v1.0.1 - 2024-02-16
 

diff --git a/Reqnroll/ITestRunner.cs b/Reqnroll/ITestRunner.cs
@@ -10,6 +10,7 @@ public interface ITestRunner
         string TestWorkerId { get; }
         FeatureContext FeatureContext { get; }
         ScenarioContext ScenarioContext { get; }
+        ITestThreadContext TestThreadContext { get; }
 
         void InitializeTestRunner(string testWorkerId);
 

diff --git a/Reqnroll/Infrastructure/ITestExecutionEngine.cs b/Reqnroll/Infrastructure/ITestExecutionEngine.cs
@@ -7,6 +7,7 @@ public interface ITestExecutionEngine
     {
         FeatureContext FeatureContext { get; }
         ScenarioContext ScenarioContext { get; }
+        ITestThreadContext TestThreadContext { get; }
 
         Task OnTestRunStartAsync();
         Task OnTestRunEndAsync();

diff --git a/Reqnroll/TestRunner.cs b/Reqnroll/TestRunner.cs
@@ -15,15 +15,11 @@ public TestRunner(ITestExecutionEngine executionEngine)
             _executionEngine = executionEngine;
         }
 
-        public FeatureContext FeatureContext
-        {
-            get { return _executionEngine.FeatureContext; }
-        }
+        public FeatureContext FeatureContext => _executionEngine.FeatureContext;
 
-        public ScenarioContext ScenarioContext
-        {
-            get { return _executionEngine.ScenarioContext; }
-        }
+        public ScenarioContext ScenarioContext => _executionEngine.ScenarioContext;
+
+        public ITestThreadContext TestThreadContext => _executionEngine.TestThreadContext;
 
         public async Task OnTestRunStartAsync()
         {