Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message provided by Reqnroll.Microsoft.Extensions.DependencyInjection plugin when a test execution dependent service is required during [BeforeTestRun] #318

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

gasparnagy
Copy link
Contributor

🤔 What's changed?

Added a more descriptive error message to Reqnroll.Microsoft.Extensions.DependencyInjection plugin for the case when a test execution dependent service is required during [BeforeTestRun].

⚡️ What's your motivation?

Before this fix and error like System.Collections.Generic.KeyNotFoundException : The given key 'Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope' was not present in the dictionary. was thrown.

Fixes #175.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

n/a

📋 Checklist:

  • I've changed the behaviour of the code
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@gasparnagy gasparnagy marked this pull request as ready for review November 7, 2024 10:51
@gasparnagy gasparnagy requested a review from ajeckmans November 7, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants