Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsTest: Only use TestContext for output and not Console.WriteLine #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

When writing output, Reqnroll only uses TestContext and don't write to Console.
The same happens already for NUnit and xUnit.

⚡️ What's your motivation?

Fixes #298

This avoids duplicate output and that Console output of tests get mixed up.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Is there a particular reason why currently both TestContext and Console output is used?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes. (see unit test changes)
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

Copy link
Contributor

@Code-Grump Code-Grump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple. Love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs are getting mixed in Visual studio test explorer
2 participants