feat: Set groups based on OIDC #5568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
requested changes
Aug 24, 2022
fionera
force-pushed
the
feat/oidc-group-sync
branch
from
32b56bb
to
8b8de30
Compare
|
Ah shoot I just saw that now the Group will be added on every login and they are not deduped. In the WebUI there is the group multiple times now. Also old groups wont be deleted. I will make another PR that removes all groups and then relates to the new ones or diffs them. Idk yet |
|
@fionera I was just testing it out and about to report a Bug before I saw that you already caught it. |
|
Could you open an Issue for it? I dont know yet when I have time for it :) |
|
Fixed in v2.5.2588 |
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try at getting oidc groups to work