Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows setting the NODE_EXTRA_CA_CERTS variable #6217

Merged
merged 5 commits into from
Mar 11, 2023

Conversation

dostalradim
Copy link
Contributor

We have the keycloak instance signed with our internal CA and I do not like disabling of certs trusting. So we just need to append extra CA certs.

@auto-assign auto-assign bot requested a review from NGPixel March 1, 2023 07:39
@NGPixel
Copy link
Member

NGPixel commented Mar 1, 2023

I would prefer the option be named nodeExtraCaCerts rather than NODE_EXTRA_CA_CERTS to keep things consistent.

@dostalradim
Copy link
Contributor Author

That makes sense. I was inspired by the variable NODE_TLS_REJECT_UNAUTHORIZED from postgresql chart :). I am gonna change it.

@NGPixel NGPixel merged commit 12d777f into requarks:main Mar 11, 2023
davidflypei pushed a commit to davidflypei/wiki that referenced this pull request Jun 13, 2023
…#6217)

---------

Co-authored-by: Radim Dostál <radim.dostal@tetanet.cz>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
…#6217)

---------

Co-authored-by: Radim Dostál <radim.dostal@tetanet.cz>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants