Fix existing auth strategies not getting new props #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request should fix an existing authentication strategy not getting new properties after an update. It does this by using the existing function to pull in new properties and their defaults, and if any new properties are detected, write the strategy back to the database with the new defaults. Something of note, a bad auth strategy update that includes breaking default properties can break an installation, so people need to keep this in mind if this PR is merged.
NGPixel
approved these changes
Mar 17, 2023
davidflypei
pushed a commit
to davidflypei/wiki
that referenced
this pull request
Jun 13, 2023
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix an existing authentication strategy not getting new properties after an update. It does this by using the existing function to pull in new properties and their defaults, and if any new properties are detected, write the strategy back to the database with the new defaults.
Something of note, a bad auth strategy update that includes breaking default properties can break an installation, so people need to keep this in mind if this PR is merged.