remove optional dependencies #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having ENV set to the string
Just take out the entire |
|
Oh, and one more thing, as part of this PR you can remove the sections at the top of some of the test files that try to |
|
@nylen updated the tests and travis.yml file |
|
👍 thanks for taking this on. I'll merge it tomorrow if no one objects or beats me to it. |
|
YAAAYYYY!!! No problem :) |
|
@seanstrom You are welcome - I had no time to work out the bad merge on my pull request so you taking over and working on this is much appreciated. Thank you! |
|
Woo! +1 Looks awesome |
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 16, 2014
Don't allow non-require statements mixed in with module require statements. We can do this now that optional dependencies were removed in request#1173.
nylen
added a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
…pendencies remove optional dependencies
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfills #1005
Derived from #1067
This code was paraphrased from #1067 just FYI
Thanks @nemanjawork
Review @mikeal @nylen @FredKSchott @emkay