Remove domain parsing for UPN-formatted names #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out domain should be null for UPN (according to https://msdn.microsoft.com/en-us/library/windows/desktop/aa378184(v=vs.85).aspx), and breaks default domain handling for alternate UPN suffixes (eg, email-address-as-domain-username). Updated tests to match current behavior.
|
@slukovic Want to investigate whether this PR resolves your issue? |
|
Yes, this works for me. |
|
Ok then, this is a simpler and more direct patch to resolve the issue, so I think we should use it. Thanks for your work @nitzmahone, @slukovic! |
|
Thanks @Lukasa - back to your vacation! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate fix for #85. Turns out domain should be null for UPN (according to https://msdn.microsoft.com/en-us/library/windows/desktop/aa378184(v=vs.85).aspx), and breaks default domain handling for alternate UPN suffixes (eg, email-address-as-domain-username).
Updated tests to match current behavior.