note about smallvec

rerun-io · Dec 2, 2023 · 1963e56 · 1963e56
1 parent d7fff63
commit 1963e56
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/crates/re_arrow_store/src/store_event.rs b/crates/re_arrow_store/src/store_event.rs
@@ -118,6 +118,10 @@ pub struct StoreDiff {
     /// same value for both the insertion and deletion events (if any).
     ///
     /// This is not a [`TimePoint`] for performance reasons.
+    //
+    // NOTE: Empirical testing shows that a SmallVec isn't any better in the best case, and can be a
+    // significant performant drop at worst.
+    // pub times: SmallVec<[(Timeline, TimeInt); 5]>, // "5 timelines ought to be enough for anyone"
     pub times: Vec<(Timeline, TimeInt)>,
 
     /// The [`EntityPath`] associated with that row.