fix my own comments

rerun-io · Dec 2, 2023 · 2fc3627 · 2fc3627
1 parent 0e0fca4
commit 2fc3627
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/crates/re_arrow_store/src/store_gc.rs b/crates/re_arrow_store/src/store_gc.rs
@@ -620,8 +620,9 @@ impl IndexedBucketInner {
             dropped_num_bytes += removed_row_id.total_size_bytes();
 
             // col_time
-            let row_time = col_time.swap_remove(row_index).unwrap();
-            dropped_num_bytes += row_time.total_size_bytes();
+            if let Some(row_time) = col_time.swap_remove(row_index) {
+                dropped_num_bytes += row_time.total_size_bytes();
+            }
 
             // col_insert_id (if present)
             if !col_insert_id.is_empty() {

diff --git a/crates/re_log_types/src/data_table.rs b/crates/re_log_types/src/data_table.rs
@@ -619,7 +619,7 @@ impl DataTable {
             timeline: Timeline,
             times: &TimeOptVec,
         ) -> (Field, Box<dyn Array>) {
-            let data = DataTable::serialize_primitive_deque_opt(times);
+            let data = DataTable::serialize_primitive_deque_opt(times).to(timeline.datatype());
 
             let field = Field::new(timeline.name().as_str(), data.data_type().clone(), false)
                 .with_metadata([(METADATA_KIND.to_owned(), METADATA_KIND_TIME.to_owned())].into());

diff --git a/crates/re_sdk/Cargo.toml b/crates/re_sdk/Cargo.toml
@@ -69,6 +69,7 @@ webbrowser = { workspace = true, optional = true }
 
 [dev-dependencies]
 re_arrow_store.workspace = true
+re_log_types = { workspace = true, features = ["testing"] }
 
 itertools.workspace = true
 ndarray-rand.workspace = true