Skip to content

Commit

Permalink
Convert objectron proto.py back to using typing.List (#2559)
Browse files Browse the repository at this point in the history 
### What

The change from List -> list was introduced as part of:
 - #2361
 
However it seems to break objectron on python3.8:
 - #2557

Reverting just this bit causes it to work for me, though I don't fully
understand the intention or ramifications.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested https://demo.rerun.io/pr/2559 (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2559

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/4073c08/docs
Examples preview: https://rerun.io/preview/4073c08/examples
<!-- pr-link-docs:end -->
  • Loading branch information
@jleibs
jleibs authored Jun 28, 2023
1 parent 3e6e973 commit d21fefa
Showing 1 changed file with 46 additions and 46 deletions.
92 changes: 46 additions & 46 deletions examples/python/objectron/proto/objectron/proto.py
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit d21fefa

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: d21fefa Previous: 4910617 Ratio
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 3775730 ns/iter (± 72877) 2837199 ns/iter (± 5779) 1.33
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 405 ns/iter (± 1) 306 ns/iter (± 2) 1.32
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 297 ns/iter (± 0) 221 ns/iter (± 5) 1.34
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 452 ns/iter (± 0) 334 ns/iter (± 0) 1.35
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 3950521 ns/iter (± 143364) 2836833 ns/iter (± 17061) 1.39
datastore/num_rows=1000/num_instances=1000/gc/default 2665076 ns/iter (± 5458) 1703312 ns/iter (± 4670) 1.56
mono_points_arrow/generate_message_bundles 36551849 ns/iter (± 923960) 28709243 ns/iter (± 819702) 1.27
mono_points_arrow/encode_log_msg 221593122 ns/iter (± 1792955) 176986460 ns/iter (± 1131058) 1.25
mono_points_arrow_batched/generate_message_bundles 28441569 ns/iter (± 899622) 18635159 ns/iter (± 108980) 1.53
mono_points_arrow_batched/generate_messages 6279170 ns/iter (± 191900) 3530593 ns/iter (± 18263) 1.78
mono_points_arrow_batched/encode_log_msg 685709 ns/iter (± 2060) 514614 ns/iter (± 1175) 1.33
mono_points_arrow_batched/encode_total 37061632 ns/iter (± 1149519) 23554576 ns/iter (± 83069) 1.57
mono_points_arrow_batched/decode_message_bundles 10190033 ns/iter (± 251436) 7472103 ns/iter (± 12860) 1.36
mono_points_arrow_batched/decode_total 11143782 ns/iter (± 316887) 7936071 ns/iter (± 18016) 1.40
batch_points_arrow/decode_log_msg 49711 ns/iter (± 159) 37996 ns/iter (± 111) 1.31
batch_points_arrow/decode_total 54732 ns/iter (± 183) 41737 ns/iter (± 117) 1.31
arrow_mono_points/insert 2729066513 ns/iter (± 11647324) 1769839678 ns/iter (± 6448203) 1.54
arrow_mono_points/query 1395285 ns/iter (± 7733) 932068 ns/iter (± 21427) 1.50
arrow_batch_points/insert 1516177 ns/iter (± 24771) 1206892 ns/iter (± 6584) 1.26

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.