Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate and test (de)serialization code for Points2D in Rust #2383

Closed
teh-cmc opened this issue Jun 12, 2023 · 0 comments · Fixed by #2601
Closed

Generate and test (de)serialization code for Points2D in Rust #2383

teh-cmc opened this issue Jun 12, 2023 · 0 comments · Fixed by #2601
Assignees
@teh-cmc
Labels
🏹 arrow concerning arrow codegen/idl 🦀 Rust API Rust logging API

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 12, 2023 •
edited
Loading

Generate serialization and deserialization Rust code for all things that make up a Points2D, effectively dropping arrow2_convert entirely.

This requires adding roundtrip serialization tests too.
@teh-cmc teh-cmc added 🏹 arrow concerning arrow 🦀 Rust API Rust logging API codegen/idl labels Jun 12, 2023
@teh-cmc teh-cmc mentioned this issue Jun 12, 2023
Closed
@teh-cmc teh-cmc mentioned this issue Jul 5, 2023
Merged
3 tasks
teh-cmc added a commit that referenced this issue Jul 6, 2023
@teh-cmc
End-to-end cross-language roundtrip tests for our archetypes (#2601)
4360deb 
With this PR, the CI will now compare the results of logging our
archetypes across all of our SDKs.

You can run it locally with:
```
./scripts/ci/run_e2e_roundtrip_tests.py --no-build
```

E.g.:

![image](https://github.com/rerun-io/rerun/assets/2910679/38f1541e-20ef-4ebd-8d55-ee6215fefd3c)


Requires #2597 

Fixes #2383 
Fixes #2384 
Fixes #2386 

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2601) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2601)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fend_to_end_roundtrips_ci/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fend_to_end_roundtrips_ci/examples)
teh-cmc added a commit that referenced this issue Jul 6, 2023
@teh-cmc
End-to-end cross-language roundtrip tests for our archetypes (#2601)
6cb2c68 
With this PR, the CI will now compare the results of logging our
archetypes across all of our SDKs.

You can run it locally with:
```
./scripts/ci/run_e2e_roundtrip_tests.py --no-build
```

E.g.:

![image](https://github.com/rerun-io/rerun/assets/2910679/38f1541e-20ef-4ebd-8d55-ee6215fefd3c)


Requires #2597 

Fixes #2383 
Fixes #2384 
Fixes #2386 

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2601) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2601)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fend_to_end_roundtrips_ci/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fend_to_end_roundtrips_ci/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🏹 arrow concerning arrow codegen/idl 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

End-to-end cross-language roundtrip tests for our archetypes rerun-io/rerun
1 participant
@teh-cmc