Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Windows/MSVC full support + testing on CI #3756

Closed
Tracked by #2919
Wumpf opened this issue Oct 10, 2023 · 2 comments · Fixed by #4110
Closed
Tracked by #2919

C++ Windows/MSVC full support + testing on CI #3756

Wumpf opened this issue Oct 10, 2023 · 2 comments · Fixed by #4110
Labels
🌊 C++ API C/C++ API specific 🪟 windows Problems specific to the Windows OS
Milestone
0.10.1

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 10, 2023 •
edited
Loading

No description provided.

@Wumpf Wumpf mentioned this issue Oct 10, 2023
Closed
33 tasks
@Wumpf Wumpf changed the title Windows support (including CI!) C++ Windows/MSVC full support + testing on CI Oct 10, 2023
@Wumpf Wumpf added 🌊 C++ API C/C++ API specific 🪟 windows Problems specific to the Windows OS labels Oct 10, 2023
@Wumpf Wumpf added this to the 0.10 C++ milestone Oct 10, 2023
@emilk emilk added the 🧑‍💻 dev experience developer experience (excluding CI) label Oct 23, 2023
@emilk
Copy link
Member

emilk commented Oct 23, 2023

For 0.10, let's just try to compile once on MSVC and take it from there.

@Wumpf Wumpf removed the 🧑‍💻 dev experience developer experience (excluding CI) label Oct 24, 2023
@emilk emilk mentioned this issue Oct 24, 2023
Closed
@Wumpf Wumpf mentioned this issue Oct 25, 2023
Merged
4 tasks
Wumpf added a commit that referenced this issue Oct 26, 2023
@Wumpf
Fix issues for using C++ on Windows (#4011)
fab45c3 
### What

A wild mix between:
* improve CMake script
* fix CMake warnings
* improve documentation
* fix windows artifact bundling
* fix compile errors & warnings
* fix Rerun pixi setup for windows

Unless I tainted my system environment to much, this PR will make `pixi
run cpp-build-all` work out of the box on Windows given that there is a
VS2022 install present.

Fixes a big chunk of:
* #3756

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4011) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4011)
- [Docs
preview](https://rerun.io/preview/2e9215adee8737f2ef27803185f996364513c8fd/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/2e9215adee8737f2ef27803185f996364513c8fd/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@Wumpf
Copy link
Member Author

Wumpf commented Oct 30, 2023

Things work fine on Windows. We "just" need to add CI now

@emilk emilk modified the milestones: 0.10 C++, 0.10.1 Oct 30, 2023
@Wumpf Wumpf mentioned this issue Nov 1, 2023
Merged
4 tasks
Wumpf added a commit that referenced this issue Nov 1, 2023
@Wumpf
C++ Windows CI (#4110)
7bf3153 
### What

* Fixes #3756
* Run VS2022 C++ tests as part of pull request CI.
* decided to go pull request for now because it's very easy to break C++
things on one compiler while you're on any of the other compilers
* This is a 12min windows job currently which *also* has to build
rerun_c for windows first
* in the future we'd ideally just skip most C++ jobs if no cpp/hpp/h
file has changed!
* Enable warnings as errors for msvc

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4110) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4110)
- [Docs
preview](https://rerun.io/preview/f5d9cc2f5b6ea8907e82a2bcd7ade265457beb49/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/f5d9cc2f5b6ea8907e82a2bcd7ade265457beb49/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific 🪟 windows Problems specific to the Windows OS
Projects
None yet
Milestone
0.10.1
Development

Successfully merging a pull request may close this issue.

C++ Windows CI rerun-io/rerun
2 participants
@emilk @Wumpf