-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scroll-to-zoom on web #965
Comments
This is very painful and makes the colmap demo nearly unusable on systems that only have a mouse with discrete zoom steps. This is a single zoom "step" for me at the moment. I have no way to zoom to a level between "too far out" and "too close in." |
This has gotten somewhat better on native recently, but it's noticeably much much worse on web. |
Problem: when radius shrinks, scrolling no longer does much. This makes the user think something is broken. Solution: switch to dolly when radius is small enough. That way scrolling will always move you closer, one way or another. Closes #965 (but does not address os-specific scroll/zoom speed problems) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
This is still quite broken on web. Here's video of scrolling a single step with scroll-wheel on linux. scroll.mp4 |
Here it is on Web on my Mac, scrolling one mouse step at a time (on my mouse): It is pretty worrying that the Btw, why isn't the scroll smoothed @Wumpf? I know you added code for that, and if I scroll faster I get the smoothed behavior, but @jleibs doesn't. Perhaps he get many duplicates of the wheel events? This is what I see under the "Inspection -> Input" panel in egui.rs when I scroll very quickly with a mouse wheel: Here I get eight scroll lines in one go. If I scroll slower I only get one scroll line at a time (as expected). If Linux is misbehaving we could consider special treatment on Linux, and just count the number of wheel events and ignore their magnitude (on Linux). |
Please try #4668 on Linux and see how zooming feels these days |
done! |
The above issues are still present: This is one wheel click forward/backward: 2024-01-04.18-34-47.mp4 |
egui.rs also gives me points but shows +/- 13 for a single notch on the scroll wheel |
The smaller the camera distance, the smaller the orbit camera movement via scroll wheel should be (3d space view)
This is already the case, but it's often still hard to accurately zoom in.
Demonstration of problem on Linux:
zoom_jump.mov
The text was updated successfully, but these errors were encountered: