Update to latest egui + use new Image api #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🚜 refactor
|
emilk
approved these changes
Sep 13, 2023
| @@ -10,6 +12,10 @@ impl Icon { | |||
| pub const fn new(id: &'static str, png_bytes: &'static [u8]) -> Self { | |||
| Self { id, png_bytes } | |||
| } | |||
|
|
|||
| pub fn as_image(&self) -> Image<'static> { | |||
There was a problem hiding this comment.
could be an impl From<&Icon> for Image<'static>
Comment on lines
+558
to
+560
| if let Ok(TexturePoll::Ready { texture }) = icon_image.load(ui) { | ||
| icon_image.paint_at(ui, self.icon_rect, &texture); | ||
| } |
There was a problem hiding this comment.
We do this pattern a lot now. We should make sure something like this works instead:
Suggested change
| if let Ok(TexturePoll::Ready { texture }) = icon_image.load(ui) { | |
| icon_image.paint_at(ui, self.icon_rect, &texture); | |
| } | |
| icon_image.paint_at(ui, self.icon_rect); |
I feel like everytime we as users see a naked TexturePoll, that's a failure in the egui interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
eguito point to latest commit on Final polish for new image loading emilk/egui#3328StaticImageCache, as its a part ofeguinowegui::ImageChecklist