Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small release workflow fixes #3926

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Small release workflow fixes #3926

merged 11 commits into from
Oct 24, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Oct 19, 2023

What

  • reusable_build_and_publish_web.yml was not setting up correct version of gcloud sdk, resulting in gsutil not being authenticated, because it used an ancient GHA runner pre-installed version that did not yet support WIF
  • The post-release version bump step now bumps according to the latest published version, as opposed to bumping on top of what we just released. This means:
    • If we publish 0.9.1, and that is the latest published version according to semver ordering, then it will bump to 0.10.0-alpha.1+dev
    • If we publish 0.9.1, and that is not the latest published version according to semver ordering, because we previously published 0.10.0-alpha.5, then it will bump to 0.10.0-alpha.6+dev.
    • If we publish 0.10.0-alpha.1, and that is the latest published version according to semver ordering, then it will bump to 0.10.0-alpha.2+dev.
  • The version bump code would fail on taplo check, so now we do taplo fmt before committing the bumped version.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 19, 2023
@jprochazk jprochazk marked this pull request as draft October 19, 2023 09:05
@jprochazk jprochazk marked this pull request as ready for review October 19, 2023 12:21
scripts/ci/crates.py Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@jprochazk jprochazk requested a review from emilk October 24, 2023 09:24
@emilk emilk merged commit 7756839 into main Oct 24, 2023
35 checks passed
@emilk emilk deleted the jan/release-workflows-0 branch October 24, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants